Skip to content

Fix Sorbet RBI for Parser35 alias to Parser40 #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Earlopain merged 1 commit into from
Dec 22, 2025
Merged

Fix Sorbet RBI for Parser35 alias to Parser40 #3821

Earlopain merged 1 commit into from
Dec 22, 2025
+1 −2

Conversation

@p-linnane
Copy link
Contributor

@p-linnane p-linnane commented Dec 19, 2025

Hello. I'm a maintainer for Homebrew. Our latest bundler Dependabot PR added Prism 1.7.0 to our Gemfile.lock. Running Sorbet identified an error related to aliasing Parser35 to Parser40 with the change from Ruby 3.5.0 to 4.0.0. This PR removes the class in favor of just an alias.

sorbet/rbi/gems/prism@1.7.0.rbi:15758: Cannot initialize the class `Parser35` by constant assignment https://srb.help/4022
       15758 |Prism::Translation::Parser35 = Prism::Translation::Parser40
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    sorbet/rbi/gems/prism@1.7.0.rbi:15759: Previously defined as a class here
       15759 |class Prism::Translation::Parser35 < Prism::Translation::Parser; end
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    Sorbet does not allow treating constant assignments as class or module definitions,
    even if the initializer computes a `Module` object at runtime. See the docs for more.
Errors: 1

@p-linnane
Fix Sorbet RBI for Parser35 alias to Parser40
3688c5c 
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Earlopain
Earlopain approved these changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@Earlopain Earlopain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We check sorbet in CI but unfortunatly this rule is disabled.

@Earlopain Earlopain merged commit 4c79365 into ruby:main Dec 22, 2025
61 of 64 checks passed
@p-linnane p-linnane deleted the fix-sorbet-parser35-alias branch December 22, 2025 16:53
@KaanOzkan KaanOzkan mentioned this pull request Dec 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Earlopain Earlopain Earlopain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@p-linnane @Earlopain